webserver Work Item Rss Feed

Created Issue: BufferReader out of range exception [9741]

hannes_neukermans — Tue, 27 Nov 2012 21:55:55 GMT

I believe the contains method has a bug. If you read the one letter word L, and call method contains('L') it crashes. The solution is to use a do while loop (instead of a while).

explanation in code --
-- CreateBufferReader("H");
-- var contains = _reader.Contains('H').Should().BeTrue();

Created Issue: HTTPS "GET" request becomes "ET" [9715]

deepsouth — Mon, 12 Nov 2012 11:09:00 GMT

I have noticed that when doing https, "GET" requests are badly transcribed to "ET" (see image).
Issue confirmed with Firefox and Chrome.

Closed Issue: Listener stops working after (backlog+2) requests [7263]

jgauffin — Tue, 31 Jan 2012 05:59:32 GMT

This is for v2.0

E.g. Listener.Start(5)

After 7 requests, nothing more happens. In my requestreceived handler i use e.Response.Connection.Type = ConnectionType.Close

Is this a bug, or is it me?

Thanks!
Comments:

wont fix, no feedback

Closed Issue: FileModule throwing Exception (v2.0) [8412]

jgauffin — Tue, 31 Jan 2012 05:58:53 GMT

I think FileModule should not throw an exception in the Process function, if the file extension isn't registerd in contentTypes (line 170). Instead it should return ProcessingResult.Continue.

For example, I'm using my cgi module, and at the moment, if I'm adding the CgiModule after your FileModule to the server modules, I get the ForbiddenException when requesting a php file. This is not what the user would expect.
Comments:

true. fixed.

Closed Issue: Posting forms throws exception (v2.0) [8413]

jgauffin — Tue, 31 Jan 2012 05:57:59 GMT

EDIT: Just realized that this is not a bug but a feature. You should document somewhere, that one has to set the servers MaxContentSize to an appropriate size (or you should initialize it with a value > 0).

In the latest version of the 2.0 trunk you seem to have introduced a bug. A simple html form like

<html>
<head><title>Test</title></head>
<body>
<form method="post" action="test.html">
<input type="text" id="test" name="test" value="Test" />
<input type="submit" value="Test" />
</form>
</body>
</html>

produces the following exception:

500 - Too large body

HttpServer.HttpException: Too large body
at HttpServer.Messages.Request.set_ContentLength(NumericHeader value) in D:\Projekte\Visual Studio\OmegaHTTPd\HttpServer\Messages\Request.cs:line 245
at HttpServer.Messages.Request.Add(String name, IHeader value) in D:\Projekte\Visual Studio\OmegaHTTPd\HttpServer\Messages\Request.cs:line 188
[...]
Comments:

Initialized it to 1 000 000 bytes in the constructor

Closed Issue: RequestCookieCollection throwing Exception (v2.0) [8466]

jgauffin — Tue, 31 Jan 2012 05:56:28 GMT

I didn't look at the specs too closely, but I think empty values in cookies are allowed (at least the browser sends them and I get the exception). So throwing an the exception in RequestCookieCollection.cs [void Add(RequestCookie cookie)] at line 118 if cookie.Value is an empty string is a bad idea.
Comments:

Closed Issue: DigestAuthentication.cs needs patching [8485]

jgauffin — Tue, 31 Jan 2012 05:55:29 GMT

From
var parameters = HeaderParameterCollection.Parse(new StringReader(header.Data));
To
var parameters = HeaderParameterCollection.Parse(new StringReader(header.Data), ',');
Comments:

Closed Issue: Exception called in ReusableSocketNetworkStream Finalizer [8661]

jgauffin — Tue, 31 Jan 2012 05:54:52 GMT

Using 1.1 Build 54198 I have got the following error reported from a customer:

System.Net.Sockets.SocketException: A request to send or receive data was disallowed because the socket is not connected and (when sending on a datagram socket using a sendto call) no address was supplied
at System.Net.Sockets.Socket.Disconnect(Boolean reuseSocket)
at HttpServer.ReusableSocketNetworkStream.Dispose(Boolean disposing)
at System.Net.Sockets.NetworkStream.Finalize()

Looking at ReusableSocketNetworkStream.Dispose(bool) I see that contrary to .Net dispose pattern the socket is disposed regardless of disposing value. Could this be the problem?

If so the suggested new code would be:

protected override void Dispose(bool disposing)
{
if (disposed) return;

try
{
if (disposing)
{
if (Socket != null && Socket.Connected)
{
try
{
Socket.Disconnect(true);
}
catch (ObjectDisposedException) { }
}
}
}
finally
{
base.Dispose(disposing);
disposed = true;
}
}

Alternatively, is there a concurrency problem?

Also Close() should check the disposed property. Suggested new implementation:

public override void Close()
{
if (disposed) throw new ObjectDisposedException(GetType().FullName);
if (Socket != null && Socket.Connected)
Socket.Close(); //TODO: Maybe use Disconnect with reuseSocket=true? I tried but it took forever.

base.Close();
}
Comments:

Closed Issue: POST Request without Content-Type header gives NullReferenceException [8740]

jgauffin — Tue, 31 Jan 2012 05:51:32 GMT

a POST request without a Content-Type results in NullReferenceException exception.

client code:

Public Function WebPost(url As String, content As String) As String
Using wc As New WebClient()
wc.Proxy = Nothing
Return (wc.UploadString(New Uri(url), "POST", content))
End Using
End Function

if one adds a Content-Type: e.g.: wc.Headers("Content-Type") = "application/mine"
then it works.

Server Exception Stack Trace
--
System.NullReferenceException: Object reference not set to an instance of an object.
at HttpServer.BodyDecoders.BodyDecoderCollection.Decode(Stream stream, ContentTypeHeader contentType, Encoding encoding) in C:\Smart_Elite\webserver.codeplex.com\HttpServer\BodyDecoders\BodyDecoderCollection.cs:line 51
at HttpServer.Server.DecodeBody(IRequest request) in C:\Smart_Elite\webserver.codeplex.com\HttpServer\Server.cs:line 164
at HttpServer.Server.HandleRequest(RequestEventArgs e) in C:\Smart_Elite\webserver.codeplex.com\HttpServer\Server.cs:line 229
at HttpServer.Server.OnRequest(Object sender, RequestEventArgs e) in C:\Smart_Elite\webserver.codeplex.com\HttpServer\Server.cs:line 302

the attached patch just adds a check for contentType being null.
Comments:

Commented Issue: International support [8198]

Plus — Thu, 19 Jan 2012 16:06:48 GMT

It seems that much better to use Encoding.Default instead of Encoding.ASCII after ive replaed I can pass query string in non english language
Comments: ** Comment from web user: Plus **

Russian (cp1251) query parameters are not working without my patch.

Created Issue: 304 notmodified should not contain Content-Lenght header [9012]

barts2108 — Thu, 15 Dec 2011 10:49:43 GMT

In webserver V1.1 HttpModules.FileModule.Process the content length is given a value even if the status code is 304 (NotModified) According to RFC 2616 the 304 response should not contain a body and thus not contain a Content-Length header.

Sending a 304 status code with a content length header and the content length header is set to a value > 0, may cause problems in e.g. safari browsers.

Commented Issue: Exception called in ReusableSocketNetworkStream Finalizer [8661]

high — Thu, 08 Dec 2011 17:04:13 GMT

Ya the disposing pattern is not really followed here. Although cleaning up a socket should probably be part of the unmanaged cleanup either way. Anyways this exception is caused when a socket is disconnected causing an exception before its fully accepted. So the garbage collector ends up getting the socket calling the finalizer. And because the socket is not connected the dispose method throws an exception.

A simple fix would be

try
{
if (Socket != null && Socket.Connected)
Socket.Disconnect(true);
}
catch (SocketException se)
{
_logger.Warning("Exception on disconnecting stream", se);
}

Probably the best solution at this point seeing as I don't think the sockets are properly disposed of in all cases anyways.

Commented Issue: POST Request without Content-Type header gives NullReferenceException [8740]

angelblaze — Mon, 03 Oct 2011 14:03:36 GMT

Forget to mention this is against v2, latest SVN.

Created Issue: POST Request without Content-Type header gives NullReferenceException [8740]

angelblaze — Mon, 03 Oct 2011 13:59:20 GMT

Created Issue: HttpClientContext leaves sockets open [8663]

krenaud — Fri, 02 Sep 2011 08:19:19 GMT

See http://webserver.codeplex.com/discussions/255507

The poster's suggestion seems like a good idea to implement in code base.

Created Issue: Exception called in ReusableSocketNetworkStream Finalizer [8661]

krenaud — Thu, 01 Sep 2011 14:40:08 GMT

Created Issue: DigestAuthentication.cs need patching [8485]

juDge — Fri, 15 Jul 2011 14:54:05 GMT

From
var parameters = HeaderParameterCollection.Parse(new StringReader(header.Data));
To
var parameters = HeaderParameterCollection.Parse(new StringReader(header.Data), ',');

Created Issue: Socket problems [8473]

juDge — Tue, 12 Jul 2011 17:35:11 GMT

Latest source is used

==================================================
ResponseWriter.SendBody Failed to send body through context stream.
System.IO.IOException: Unable to write data to the transport connection: An existing connection was forcibly closed by the remote host. --->

System.Net.Sockets.SocketException: An existing connection was forcibly closed by the remote host
at System.Net.Sockets.Socket.Send(Byte[] buffer, Int32 offset, Int32 size, SocketFlags socketFlags)
at System.Net.Sockets.NetworkStream.Write(Byte[] buffer, Int32 offset, Int32 size)
--- End of inner exception stack trace ---
at System.Net.Sockets.NetworkStream.Write(Byte[] buffer, Int32 offset, Int32 size)
at HttpServer.Messages.ResponseWriter.SendBody(IHttpContext context, Stream body) in C:\HttpServer\Messages\ResponseWriter.cs:line 85
HttpParser.Reset Resetting..

==================================================

ResponseWriter.Send Failed to send data through context stream.
System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'HttpServer.Transports.ReusableSocketNetworkStream'.
at System.Net.Sockets.NetworkStream.Write(Byte[] buffer, Int32 offset, Int32 size)
at HttpServer.Messages.ResponseWriter.Send(IHttpContext context, String data, Encoding encoding) in C:\HttpServer\Messages\ResponseWriter.cs:line

62ResponseWriter.SendBody Failed to send body through context stream.
System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'HttpServer.Transports.ReusableSocketNetworkStream'.
at System.Net.Sockets.NetworkStream.Write(Byte[] buffer, Int32 offset, Int32 size)
at HttpServer.Messages.ResponseWriter.SendBody(IHttpContext context, Stream body) in C:\HttpServer\Messages\ResponseWriter.cs:line 85HttpContext.Close

Failed to close context properly.
System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'System.Net.Sockets.Socket'.
at System.Net.Sockets.Socket.Disconnect(Boolean reuseSocket)
at HttpServer.HttpContext.Close() in C:\HttpServer\HttpContext.cs:line 171HttpListener.OnSocketAccepted Accepted connection from: 217.174.169.54:51279

===================================================

HttpContext.OnReceive Failed to read from stream: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'HttpServer.Transports.ReusableSocketNetworkStream'.
at System.Net.Sockets.NetworkStream.BeginRead(Byte[] buffer, Int32 offset, Int32 size, AsyncCallback callback, Object state)
at HttpServer.HttpContext.OnReceive(IAsyncResult ar) in C:\HttpServer\HttpContext.cs:line 240

HttpContext.OnReceive Failed to read from stream: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'System.Net.Sockets.Socket'.
at System.Net.Sockets.Socket.get_RemoteEndPoint()
at HttpServer.HttpContext.OnRequest(Object sender, FactoryRequestEventArgs e) in C:\HttpServer\HttpContext.cs:line 270
at System.EventHandler`1.Invoke(Object sender, TEventArgs e)
at HttpServer.Messages.MessageFactoryContext.OnMessageComplete(Object sender, EventArgs e) in C:\HttpServer\Messages\MessageFactoryContext.cs:line 81
at System.EventHandler.Invoke(Object sender, EventArgs e)
at HttpServer.Messages.Parser.HttpParser.OnComplete() in C:\HttpServer\Messages\Parser\HttpParser.cs:line 173
at HttpServer.Messages.Parser.HttpParser.GetBody() in C:\HttpServer\Messages\Parser\HttpParser.cs:line 56
at HttpServer.Messages.Parser.HttpParser.Parse(Byte[] buffer, Int32 offset, Int32 count) in C:\HttpServer\Messages\Parser\HttpParser.cs:line 239
at HttpServer.Messages.MessageFactoryContext.Parse(Byte[] buffer, Int32 offset, Int32 length) in C:\HttpServer\Messages\MessageFactoryContext.cs:line 108
at HttpServer.HttpContext.ParseBuffer(Int32 bytesLeft) in C:\HttpServer\HttpContext.cs:line 314
at HttpServer.HttpContext.OnReceive(IAsyncResult ar) in C:\HttpServer\HttpContext.cs:line 229
================================================================================

Created Issue: RequestCookieCollection throwing Exception (v2.0) [8466]

wo80 — Tue, 12 Jul 2011 10:16:43 GMT

Created Issue: Posting forms throws exception (v2.0) [8413]

wo80 — Fri, 01 Jul 2011 13:53:25 GMT

In the latest version of the 2.0 trunk you semm to have introduced a bug. A simple html form like

<html>
<head><title>Test</title></head>
<body>
<form method="post" action="test.html">
<input type="text" id="test" name="test" value="Test" />
<input type="submit" value="Test" />
</form>
</body>
</html>

produces the following exception:

500 - Too large body

HttpServer.HttpException: Too large body
at HttpServer.Messages.Request.set_ContentLength(NumericHeader value) in D:\Projekte\Visual Studio\OmegaHTTPd\HttpServer\Messages\Request.cs:line 245
at HttpServer.Messages.Request.Add(String name, IHeader value) in D:\Projekte\Visual Studio\OmegaHTTPd\HttpServer\Messages\Request.cs:line 188
at HttpServer.Messages.MessageFactoryContext.OnHeader(Object sender, HeaderEventArgs e) in D:\Projekte\Visual Studio\OmegaHTTPd\HttpServer\Messages\MessageFactoryContext.cs:line 69
at System.EventHandler`1.Invoke(Object sender, TEventArgs e)
at HttpServer.Messages.Parser.HttpParser.OnHeader(String name, String value) in D:\Projekte\Visual Studio\OmegaHTTPd\HttpServer\Messages\Parser\HttpParser.cs:line 223
at HttpServer.Messages.Parser.HttpParser.GetHeaderValue() in D:\Projekte\Visual Studio\OmegaHTTPd\HttpServer\Messages\Parser\HttpParser.cs:line 147
at HttpServer.Messages.Parser.HttpParser.Parse(Byte[] buffer, Int32 offset, Int32 count) in D:\Projekte\Visual Studio\OmegaHTTPd\HttpServer\Messages\Parser\HttpParser.cs:line 239
at HttpServer.Messages.MessageFactoryContext.Parse(Byte[] buffer, Int32 offset, Int32 length) in D:\Projekte\Visual Studio\OmegaHTTPd\HttpServer\Messages\MessageFactoryContext.cs:line 108
at HttpServer.HttpContext.ParseBuffer(Int32 bytesLeft) in D:\Projekte\Visual Studio\OmegaHTTPd\HttpServer\HttpContext.cs:line 315
at HttpServer.HttpContext.OnReceive(IAsyncResult ar) in D:\Projekte\Visual Studio\OmegaHTTPd\HttpServer\HttpContext.cs:line 230